feat: automatic k8 operator token refreshing #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Oct 18, 2024
maidul98
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Feature seems to be working as expected but it keeps saying it wasn't able to renew periodically even though in the next iteration, it can. When we know the ttl will exceed the max ttl, we can just login instead of using the expired creds.
Here some other comments:
- I don't think we need to paint the logs yellow
- The logs say that it wasn't able to renew but i think it does? The user is never made aware that it has renewed successfully after though
- I think our approach with logging might be incorrect for the operator. When there are are more than 2 InfisicalSecret CRD, these logs aren't useful anymore because they don't contain any context for which CRD they are for. I would had some context to the SDK logs for now. I'll make a linear item to revamp our operator logs in a future PR.
maidul98
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces automatic token refreshing, which is handled internally by our Go Lang SDK.
Type ✨